use Go idiomatic naming for Architecture consts #379
Conversation
There was a problem hiding this comment.
IIRC ghw/pkg/... are also part of our public API?
A (unfortunately very quick) scan of the README seems inconclusive, even if admittedly top-level aliases are suggested most.
In any case, eventually we do report to users ghw.TopologyInfo.Architecture which is filled using the new constants, so it seems we have a small annoying backward compatibility break here :\
| ArchitectureSMP Architecture = iota | ||
| // NUMA is a Non-Uniform Memory Access system | ||
| ARCHITECTURE_NUMA | ||
| ArchitectureNUMA |
There was a problem hiding this comment.
IIRC we do allow importing sub-packages (import github.com/jaypipes/ghw/pkg/topology) and these are part of the public API. If so we need the backward compatibility also here
There was a problem hiding this comment.
Ack, makes sense. I'll add the pkg/-specific old names back in, with deprecation warnings.
Updates the `ARCHITECTURE_SMP` and `ARCHITECTURE_NUMA` constants to `ArchitectureSMP` and `ArchitectureNUMA`, respectively, to align with idiomatic Go naming conventions. For backwards-compat, keeps `ARCHITECTURE_SMP` and `ARCHITECTURE_NUMA` in the aliased variables for a few releases. These will be discarded when we cut a v1.0 series. Signed-off-by: Jay Pipes <jaypipes@gmail.com>
|
Thanks @jaypipes I think this is the best we can do atm. |
Updates the
ARCHITECTURE_SMPandARCHITECTURE_NUMAconstants toArchitectureSMPandArchitectureNUMA, respectively, to align with idiomatic Go naming conventions.For backwards-compat, keeps
ARCHITECTURE_SMPandARCHITECTURE_NUMAin the aliased variables for a few releases. These will be discarded when we cut a v1.0 series.