Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in actually overhauling the ghw library's context package and moving to a more standard
context.Context
usage. In order to standardize the context usage, we needed to change the way that the ghw-snapshot functionality worked to manually construct apkg/context.Context
and callpkg/context.Context:Do()
while reading the snapshot tarball.In order to do that, I created a new
ghw-snapshot read
command that accepts a single argument to the snapshot tarball path to read:A followup series of patches will make the aforementioned changes to
pkg/context
and remove thepkg/context.Context:Do()
method and put that entirely in thecmd/ghw-snapshot/command/read.go
file which is the only place we actually use it.