Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not support Django 4.0 #766

Closed
markflorence728 opened this issue Jan 8, 2022 · 6 comments
Closed

Not support Django 4.0 #766

markflorence728 opened this issue Jan 8, 2022 · 6 comments

Comments

@markflorence728
Copy link

https://docs.djangoproject.com/en/4.0/releases/4.0/#:~:text=django.utils.encoding.force_text()%20and%20smart_text()%20are%20removed.

from django.utils.encoding import smart_bytes, force_text

There is an invalid function that is removed in django4.0..
We must replace django.utils.encoding.force_text() to django.utils.encoding.force_str()

Hope to see a fast upgrade for django4.0 support

@kevinmarsh
Copy link
Contributor

There's an approved PR #760 for this, just waiting for it to be merged and released (maybe @cyberdelia or @TheBuky will have some time?)

@markflorence728
Copy link
Author

markflorence728 commented Jan 10, 2022 via email

@Pyvonix
Copy link

Pyvonix commented Jan 10, 2022

Thank for the PR and the support of Django 4.0

I have start to work on it last week, but I get some trouble documented as #765 with an old python package to minify JS. I will drop the support for slimit, we should past tests and the packages will be release.

@Pyvonix
Copy link

Pyvonix commented Jan 10, 2022

All tests past after slimit removed but the automated task to push the release 2.0.8 failed... File already exists.

I report the issue.
Many things have changed in Jazzband, now it's the project lead to see that. Can you look at why an error @cyberdelia happen during the publishing process?

@cyberdelia
Copy link
Member

@TheBuky Looks like it's conflicting with the previously unreleased 2.0.8 you did a few days ago, I removed that upload and re-released.

@Pyvonix
Copy link

Pyvonix commented Jan 10, 2022

Oh my bad, I didn't think the previous unreleased version could block this one. Thank for fixing it!
The package is now on Pypi @markflorence728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants