Issue #598 extend support for the hashmap functions #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
========================================
+ Coverage 63.3% 64.3% +1.1%
========================================
Files 43 43
Lines 3215 3389 +174
Branches 244 287 +43
========================================
+ Hits 2034 2179 +145
- Misses 1164 1192 +28
- Partials 17 18 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
WisdomPill
requested changes
Oct 20, 2024
| def test_hsetnx(self, cache: RedisCache): | ||
| result_foo1 = cache.hsetnx("foo_hash1", "foo1", "bar1") | ||
| result_foo2 = cache.hsetnx("foo_hash1", "foo2", "bar2") | ||
| result_foo2_1 = cache.hsetnx("foo_hash1", "foo2", "bar2") |
There was a problem hiding this comment.
could you change the value written?
Suggested change
| result_foo2_1 = cache.hsetnx("foo_hash1", "foo2", "bar2") | |
| result_foo2_1 = cache.hsetnx("foo_hash1", "foo2", "bar3") |
|
@rootart do you have time to finish this PR? otherwise I can take it... that said, thanks for the effort you've put in this project so far, it is highly appreciated 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.