updates CustomHistoricalAttrsTest test to use TestCase setUp

jazzband · Sep 25, 2023 · eed2f52 · eed2f52
1 parent b26f5ce
commit eed2f52
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/simple_history/tests/tests/test_utils.py b/simple_history/tests/tests/test_utils.py
@@ -514,13 +514,16 @@ def test_bulk_update_history_wrong_manager(self):
 
 class CustomHistoricalAttrsTest(TestCase):
 
-    def test_bulk_create_history_with_custom_model_attributes(self):
-        data = [
+    def setUp(self):
+        self.data = [
             PollWithHistoricalSessionAttr(id=x, question='Question ' + str(x))
             for x in range(5)
         ]
+
+    def test_bulk_create_history_with_custom_model_attributes(self):
+
         bulk_create_with_history(
-            data, PollWithHistoricalSessionAttr,
+            self.data, PollWithHistoricalSessionAttr,
             custom_historical_attrs={'session': 'jam'}
         )
 
@@ -531,13 +534,6 @@ def test_bulk_create_history_with_custom_model_attributes(self):
         )
 
     def test_bulk_update_history_with_custom_model_attributes(self):
-        create_data = [
-            PollWithHistoricalSessionAttr(id=x, question='Question ' + str(x))
-            for x in range(5)
-        ]
-
-        bulk_create_with_history(create_data, PollWithHistoricalSessionAttr)
-
         update_data = [
             PollWithHistoricalSessionAttr(id=x, question='Q' + str(x))
             for x in range(5)