Make skip_history_when_saving work when creating a new object
#1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
+ Coverage 96.84% 96.87% +0.02%
==========================================
Files 24 23 -1
Lines 1457 1278 -179
Branches 240 211 -29
==========================================
- Hits 1411 1238 -173
+ Misses 25 21 -4
+ Partials 21 19 -2 ☔ View full report in Codecov by Sentry. |
ddabble
force-pushed
the
feature/skip-history-when-creating
branch
from
bf22f55 to
54fcd0b
Compare
ddabble
requested review from
valberg and
theryanwalker
and removed request for
valberg
ddabble
force-pushed
the
feature/skip-history-when-creating
branch
from
54fcd0b to
a1f85a9
Compare
...a model object - not just when updating an object. Also improved the docs on saving without creating historical records, and fixed an unrelated `PollWithManyToMany` instance being used in the assertions in the existing test for `skip_history_when_saving`.
ddabble
force-pushed
the
feature/skip-history-when-creating
branch
from
a1f85a9 to
3c2319c
Compare
tim-schilling
requested changes
Jun 7, 2024
Co-authored-by: Tim Schilling <schilling711@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
skip_history_when_savingused to only apply when updating an existing object (due to thenot createdoperand inpost_save()), not when creating a new one. This PR fixes that.Also improved the docs on saving without creating historical records.
Related Issue
Closes #1141.
Motivation and Context
Fixing the linked issue.
How Has This Been Tested?
See the test added in
test_models.py.Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst