Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added related_name to both OutstandingToken as well as BlacklistedToken #720

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tpotjj
Copy link

@tpotjj tpotjj commented Jun 29, 2023

Not a huge change, but this would make the reverse relation reference easier from both the user perspective as well as the OutstandingToken perspective:

user.outstandingtoken_set becomes user.outstanding_tokens

The same for the BlacklistedToken

@tpotjj
Copy link
Author

tpotjj commented Jul 3, 2023

@Andrew-Chen-Wang Ready for review.

@Andrew-Chen-Wang
Copy link
Member

this is a breaking change. also requires a new migration

breaking change will need to wait for new major version

@tpotjj
Copy link
Author

tpotjj commented Jul 5, 2023

@Andrew-Chen-Wang do I need to make those migrations? Or is that something that happens throughout the release of a new major version?
And is there anything else I need to do?

@Andrew-Chen-Wang
Copy link
Member

need new migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants