Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage #722

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

kiraware
Copy link
Member

@kiraware kiraware commented Jul 2, 2023

Increase coverage by add more tests. Almost 100% coverage :)

Copy link
Member Author

@kiraware kiraware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrew-Chen-Wang Ready for review.

Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you!

raise ImportError
return realimport(name, globals, locals, fromlist, level)

realimport = builtins.__import__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibility of failure during assertions, so cleanup needs to be done better. Perhaps in setup, you can set realimport = builtins.__import__

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've update the setUp(). Could you please review and correct me if i'm wrong.

Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Andrew-Chen-Wang Andrew-Chen-Wang merged commit c3cfd3e into jazzband:master Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants