Enhance BlacklistMixin with Generic Type for Accurate Type Inference #768
Conversation
| T = TypeVar("T", bound="Token") | ||
|
|
There was a problem hiding this comment.
Bounded context. Looks good to me.
tests/test_init.py
Outdated
|
|
||
|
|
||
| class TestInit(SimpleTestCase): | ||
| def test_package_is_not_installed(self): | ||
| with patch( | ||
| "pkg_resources.get_distribution", Mock(side_effect=DistributionNotFound) | ||
| "importlib.metadata.version", Mock(side_effect=PackageNotFoundError) |
There was a problem hiding this comment.
Thank you for making this patch, moving from legacy pkg_resources to importlibis a positive move forward to accessing modules metadata.
tldr; Looks good to me.
There was a problem hiding this comment.
Thanks. This really just reflects the changes that were made to rest_framework_simplejwt/__init__.py in 19cf38e
There was a problem hiding this comment.
A few tox tests seems to be breaking, though. Mostly version-dependent tests.
There was a problem hiding this comment.
There are a few tests that seem to not have been passing for a while. I just opened #769 to consolidate the fixes, and I'll update this MR to remove the tests fixes.
There was a problem hiding this comment.
Oh great this should be ready for ready for merge then, @Andrew-Chen-Wang just merged #769
|
Tests should pass once #769 is merged. |
|
Thank you @Dresdn and @50-Course ! |
Closes #767