Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve policy comma handling #74

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

m-ignatov
Copy link
Contributor

@m-ignatov m-ignatov commented Aug 6, 2024

@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 6, 2024

@m-ignatov plz fix all errors:

image

@m-ignatov m-ignatov changed the title Casbin comma handling fix: policy comma handling Aug 7, 2024
@m-ignatov
Copy link
Contributor Author

@hsluoyz Moving escapeCasbinRule() & escapeSingleRule() to org.casbin.jcasbin.util.Util will clear the errors in the Codebeat scan I guess, but let me know if this change is okay and will proceed.

@hsluoyz
Copy link
Member

hsluoyz commented Aug 7, 2024

@m-ignatov

  1. Run all tests in your localhost beforehand, don't test it here
  2. sign CLA

@m-ignatov
Copy link
Contributor Author

@hsluoyz

  1. Tested and the build seems to pass
  2. I have agreed already, not sure why it does not update here:
image

@hsluoyz hsluoyz changed the title fix: policy comma handling feat: improve policy comma handling Aug 7, 2024
@hsluoyz hsluoyz merged commit 8e86da1 into jcasbin:master Aug 7, 2024
2 of 4 checks passed
@m-ignatov
Copy link
Contributor Author

@hsluoyz it seems the master pipeline has failed deploying the 2.8.0 version to Maven. Could you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Casbin comma handling over JDBC Adapter
5 participants