Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store generic (non-string) values #15

Open
jdockerty opened this issue Apr 10, 2024 · 0 comments · May be fixed by #22
Open

Store generic (non-string) values #15

jdockerty opened this issue Apr 10, 2024 · 0 comments · May be fixed by #22

Comments

@jdockerty
Copy link
Owner

jdockerty commented Apr 10, 2024 •
edited
Loading

The store only works for values that are String.

https://github.com/jdockerty/sqrl/blob/9055210006cc31bd6996d2dc5ce22ea5afd3522b/src/store.rs#L96-L98

This should be converted to storing generic values, keeping keys as String I think is okay for now.

As a reference, I believe we should be able to look in the standard library at how this is implemented for HashMap or any other K-V library (e.g. DashMap).
@jdockerty jdockerty changed the title Store generic data Store generic (non-string) values Apr 10, 2024
@jdockerty jdockerty linked a pull request Apr 18, 2024 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce Value jdockerty/squirrel
1 participant
@jdockerty