Cut dependencies of Iceberg on UI

- Remove #morphicOpen: that is dead code - Move IceMergeResolationRequest>>defaultAction to Iceberg-TipUI since it is here to open the Tip UI - Move IceExperimentalFeature to Iceberg since this is raised in Iceberg's code and not in the UI code
jecisc · Jun 24, 2024 · b5f7711 · b5f7711
1 parent 4c9079e
commit b5f7711
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 43 deletions.
diff --git a/Iceberg-TipUI/IceMergeResolutionRequest.extension.st b/Iceberg-TipUI/IceMergeResolutionRequest.extension.st
@@ -0,0 +1,19 @@
+Extension { #name : 'IceMergeResolutionRequest' }
+
+{ #category : '*Iceberg-TipUI' }
+IceMergeResolutionRequest >> defaultAction [
+
+	| window mergeMorph |
+	mergeMorph := (IceTipMergeMorph forMerger: merge).
+
+	mergeMorph
+		fromDescription: merge sourceDescription;
+		toDescription: merge targetDescription.
+
+	window := mergeMorph newWindow
+		title: 'Merge';
+		yourself.
+
+	window openModal.
+	^ mergeMorph merged
+]
diff --git a/...erg-TipUI/IceExperimentalFeature.class.st → Iceberg/IceExperimentalFeature.class.st b/...erg-TipUI/IceExperimentalFeature.class.st → Iceberg/IceExperimentalFeature.class.st
@@ -6,9 +6,9 @@ This is useful to guarantee the correct keeping of the changes.
 Class {
 	#name : 'IceExperimentalFeature',
 	#superclass : 'IceWarning',
-	#category : 'Iceberg-TipUI-Exceptions',
-	#package : 'Iceberg-TipUI',
-	#tag : 'Exceptions'
+	#category : 'Iceberg-Errors',
+	#package : 'Iceberg',
+	#tag : 'Errors'
 }
 
 { #category : 'visiting' }

diff --git a/Iceberg/IceMergeResolutionRequest.class.st b/Iceberg/IceMergeResolutionRequest.class.st
@@ -9,24 +9,6 @@ Class {
 	#tag : 'Errors'
 }
 
-{ #category : 'exception description' }
-IceMergeResolutionRequest >> defaultAction [
-
-	| window mergeMorph |
-	mergeMorph := (IceTipMergeMorph forMerger: merge).
-
-	mergeMorph
-		fromDescription: merge sourceDescription;
-		toDescription: merge targetDescription.
-
-	window := mergeMorph newWindow
-		title: 'Merge';
-		yourself.
-
-	window openModal.
-	^ mergeMorph merged
-]
-
 { #category : 'accessing' }
 IceMergeResolutionRequest >> merge [
 	^ merge

diff --git a/Iceberg/IceMetacelloRepositoryAdapter.class.st b/Iceberg/IceMetacelloRepositoryAdapter.class.st
@@ -124,24 +124,6 @@ IceMetacelloRepositoryAdapter >> loadPackageNamed: aName intoLoader: aLoader [
 		  self }
 ]
 
-{ #category : 'MonticelloGUI' }
-IceMetacelloRepositoryAdapter >> morphicOpen: workingCopy [
-
-	| shouldOpenIceberg |
-	shouldOpenIceberg := 
-		SpApplication defaultApplication newConfirm
-			title: 'Browsing an iceberg repository';
-			label:  ('{1} belongs to {2} and cannot be browsed here. 
-Do you want to open the Iceberg Browser instead?' format: {
-					                      workingCopy packageName.
-					                      self repository name });
-			acceptLabel: 'Open';
-			cancelLabel: 'Cancel';
-		   openModal.
-	shouldOpenIceberg ifFalse: [ ^ self ].
-	IceTipRepositoriesBrowser new open
-]
-
 { #category : 'accessing' }
 IceMetacelloRepositoryAdapter >> packageNamed: aName [
 

diff --git a/Iceberg-TipUI/IceWarning.class.st → Iceberg/IceWarning.class.st b/Iceberg-TipUI/IceWarning.class.st → Iceberg/IceWarning.class.st
@@ -1,12 +1,12 @@
 "
-I'm a general warning in the context of iceberg UI.
+I'm a general warning in the context of iceberg.
 "
 Class {
 	#name : 'IceWarning',
 	#superclass : 'Warning',
-	#category : 'Iceberg-TipUI-Exceptions',
-	#package : 'Iceberg-TipUI',
-	#tag : 'Exceptions'
+	#category : 'Iceberg-Errors',
+	#package : 'Iceberg',
+	#tag : 'Errors'
 }
 
 { #category : 'visiting' }