Skip to content

Commit

Permalink
Avoid useless garbage collects
Browse files Browse the repository at this point in the history
Some garbage collects seems useless in Iceberg tests (I ran the tests multiple times without troubles) and are slowing down Iceberg tests
  • Loading branch information
jecisc committed Nov 21, 2023
1 parent 83aea5c commit dbb753b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions Iceberg-Tests/IceGitTestFactory.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,9 @@ IceGitTestFactory >> remoteFileUrl [

{ #category : 'initialization' }
IceGitTestFactory >> tearDownWithRepository: aRepository [

aRepository ifNotNil: [
aRepository free.
Smalltalk garbageCollect.
aRepository location ifNotNil: #ensureDeleteAll ].
self remoteFileUrl asFileReference ensureDeleteAll
]
3 changes: 1 addition & 2 deletions Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,5 @@ IceNotYetClonedRepositoryFixture >> setUp [
{ #category : 'running' }
IceNotYetClonedRepositoryFixture >> tearDown [

Smalltalk garbageCollect.
self location ifNotNil: #ensureDeleteAll.
self location ifNotNil: #ensureDeleteAll
]

0 comments on commit dbb753b

Please sign in to comment.