Prevent the browsing of a removed element

Fixes pharo-project/pharo#14300 As a bonus I fixed some protocols
jecisc · Jul 28, 2023 · f200db4 · f200db4
1 parent d5f3d1e
commit f200db4
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/Iceberg-TipUI/IceTipAddRemoteCommand.class.st b/Iceberg-TipUI/IceTipAddRemoteCommand.class.st
@@ -19,7 +19,7 @@ IceTipAddRemoteCommand class >> defaultName [
 	^ 'Add remote'
 ]
 
-{ #category : #executing }
+{ #category : #testing }
 IceTipAddRemoteCommand >> canBeExecuted [
 	"Any repository can have more remotes."
 

diff --git a/Iceberg-TipUI/IceTipBrowseCommand.class.st b/Iceberg-TipUI/IceTipBrowseCommand.class.st
@@ -19,11 +19,11 @@ IceTipBrowseCommand class >> defaultName [
 	^ 'Browse...'
 ]
 
-{ #category : #executing }
+{ #category : #testing }
 IceTipBrowseCommand >> canBeExecuted [
+	"In the case of a method removal it is not possible to browse the selected element."
 
-	^ self hasSelectedItem
-
+	^ self hasSelectedItem and: [ self item value definition canBeBrowsed ]
 ]
 
 { #category : #executing }

diff --git a/Iceberg-TipUI/IceTipInspectCommand.class.st b/Iceberg-TipUI/IceTipInspectCommand.class.st
@@ -19,7 +19,7 @@ IceTipInspectCommand class >> defaultName [
 	^ 'Inspect...'
 ]
 
-{ #category : #executing }
+{ #category : #testing }
 IceTipInspectCommand >> canBeExecuted [
 
 	^ self context hasSelectedItem

diff --git a/Iceberg-TipUI/IceTipRemotesTreeCommand.class.st b/Iceberg-TipUI/IceTipRemotesTreeCommand.class.st
@@ -31,7 +31,7 @@ IceTipRemotesTreeCommand >> actsOnTag: aTagModel [
 	^ false
 ]
 
-{ #category : #executing }
+{ #category : #testing }
 IceTipRemotesTreeCommand >> canBeExecuted [
 
 	^ self hasSelectedItem and: [ self item canActivateCommand: self ]

diff --git a/Iceberg-TipUI/IceTipTreeCollapseCommand.class.st b/Iceberg-TipUI/IceTipTreeCollapseCommand.class.st
@@ -20,7 +20,7 @@ IceTipTreeCollapseCommand class >> defaultName [
 	^ 'Collapse'
 ]
 
-{ #category : #executing }
+{ #category : #testing }
 IceTipTreeCollapseCommand >> canBeExecuted [
 
 	^ self hasSelectedItem

diff --git a/Iceberg-TipUI/IceTipTreeExpandCommand.class.st b/Iceberg-TipUI/IceTipTreeExpandCommand.class.st
@@ -19,7 +19,7 @@ IceTipTreeExpandCommand class >> defaultName [
 	^ 'Expand'
 ]
 
-{ #category : #executing }
+{ #category : #testing }
 IceTipTreeExpandCommand >> canBeExecuted [
 
 	^ self hasSelectedItem