forked from twentyhq/twenty
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Load all data on record boards (twentyhq#5070)
## Context For users with many records, only the first n*60 records were loaded on board views (n being the number of visible columns). This was because of the following behavior: - watch for end of column visibility changes. If an end of column is visible, try to fetch more. However, watching for visbility changes is not reliable enough. ## What we want If an end of column is visible, try to fetch more. If no more records is availble in pagination, do not fetch more
- Loading branch information
1 parent
d3170fc
commit 4bd2cdd
Showing
9 changed files
with
84 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 0 additions & 7 deletions
7
...object-record/record-board/states/onRecordBoardFetchMoreVisibilityChangeComponentState.ts
This file was deleted.
Oops, something went wrong.
7 changes: 7 additions & 0 deletions
7
...ject-record/record-board/states/recordBoardShouldFetchMoreInColumnComponentFamilyState.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { createComponentFamilyState } from '@/ui/utilities/state/component-state/utils/createComponentFamilyState'; | ||
|
||
export const recordBoardShouldFetchMoreInColumnComponentFamilyState = | ||
createComponentFamilyState<boolean, string>({ | ||
key: 'onRecordBoardFetchMoreIrecordBoardShouldFetchMoreInColumnComponentFamilyStatesVisibleComponentFamilyState', | ||
defaultValue: false, | ||
}); |
28 changes: 28 additions & 0 deletions
28
...record/record-board/states/selectors/recordBoardShouldFetchMoreComponentFamilySelector.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { recordBoardColumnIdsComponentState } from '@/object-record/record-board/states/recordBoardColumnIdsComponentState'; | ||
import { recordBoardShouldFetchMoreInColumnComponentFamilyState } from '@/object-record/record-board/states/recordBoardShouldFetchMoreInColumnComponentFamilyState'; | ||
import { createComponentReadOnlySelector } from '@/ui/utilities/state/component-state/utils/createComponentReadOnlySelector'; | ||
|
||
export const recordBoardShouldFetchMoreComponentSelector = | ||
createComponentReadOnlySelector<boolean>({ | ||
key: 'recordBoardShouldFetchMoreComponentSelector', | ||
get: | ||
({ scopeId }: { scopeId: string }) => | ||
({ get }) => { | ||
const columnIds = get( | ||
recordBoardColumnIdsComponentState({ | ||
scopeId, | ||
}), | ||
); | ||
|
||
const shouldFetchMoreInColumns = columnIds.map((columnId) => { | ||
return get( | ||
recordBoardShouldFetchMoreInColumnComponentFamilyState({ | ||
scopeId, | ||
familyKey: columnId, | ||
}), | ||
); | ||
}); | ||
|
||
return shouldFetchMoreInColumns.some(Boolean); | ||
}, | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters