#68 - addressing strange behaviour caused by Yosemite support impleme…

…ntation
jeevatkm · Sep 12, 2014 · 462c56e · 462c56e
1 parent fea5e16
commit 462c56e
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 7 deletions.
diff --git a/ReplyWithHeader.xcodeproj/xcshareddata/xcschemes/ReplyWithHeader.xcscheme b/ReplyWithHeader.xcodeproj/xcshareddata/xcschemes/ReplyWithHeader.xcscheme
@@ -39,6 +39,9 @@
       ignoresPersistentStateOnLaunch = "NO"
       debugDocumentVersioning = "YES"
       allowLocationSimulation = "YES">
+      <PathRunnable
+         FilePath = "/Applications/Mail.app">
+      </PathRunnable>
       <AdditionalOptions>
          <AdditionalOption
             key = "DYLD_INSERT_LIBRARIES"

diff --git a/ReplyWithHeader/MHQuotedMailOriginal.m b/ReplyWithHeader/MHQuotedMailOriginal.m
@@ -70,7 +70,7 @@ - (void)insertForHTMLMail:(DOMDocumentFragment *)headerFragment
 {
     if (isBlockquotePresent)
     {
-        DOMNode *nodeRef = [self getElementByName:TAG_BLOCKQUOTE];
+        DOMNode *nodeRef = [self getBlockquoteTagNode];
         [nodeRef insertBefore:headerFragment refChild:[nodeRef firstChild]];
         [nodeRef insertBefore:headerBorder refChild:[nodeRef firstChild]];
     }
@@ -83,11 +83,11 @@ - (void)insertForHTMLMail:(DOMDocumentFragment *)headerFragment
 
 - (void)insertForPlainMail:(DOMDocumentFragment *)headerFragment
 {
-    if ( textNodeLocation >= 0 )
+    if (textNodeLocation >= 0)
     {
         if (isBlockquotePresent) // include inside blockquote
         {
-            DOMNode *nodeRef = [self getElementByName:TAG_BLOCKQUOTE];
+            DOMNode *nodeRef = [self getBlockquoteTagNode];
             [nodeRef insertBefore:headerFragment refChild:[nodeRef firstChild]];
             [nodeRef insertBefore:headerBorder refChild:[nodeRef firstChild]];
         }
@@ -164,7 +164,7 @@ - (id)initWithMailMessage:(id)mailMessage msgComposeType:(int)composeType
         dhc = [originalEmail childNodes];
 
         //identifying blockquote tag
-        isBlockquotePresent = [self isTagPresent:TAG_BLOCKQUOTE];
+        isBlockquotePresent = [self isBlockquoteTagPresent]; //[self isTagPresent:TAG_BLOCKQUOTE];
 
         //now get the quoted content and remove the first part (where it says "On ... X wrote"
         // "... message"
@@ -295,7 +295,7 @@ - (void)removeHTMLHeaderPrefix
 
             while ( textRange.location == NSNotFound )
             {
-                [emailDocument removeChild:[nodeList item:0]];
+                [emailDocument removeChild:[emailDocument firstChild]];
                 textRange = [[[emailDocument firstChild] stringValue] rangeOfString:searchString];
             }
         }
@@ -365,6 +365,38 @@ - (void)prepareQuotedPlainText
     }
 }
 
+- (BOOL)isBlockquoteTagPresent
+{
+    BOOL present = FALSE;
+
+    for (int i=0; i < dhc.length; i++)
+    {
+        if ([[[dhc item:i] nodeName] isEqualToString:TAG_BLOCKQUOTE])
+        {
+            present = TRUE;
+            MHLog(@"%@ Node found at %d", TAG_BLOCKQUOTE, i);
+            break;
+        }
+    }
+
+    return present;
+}
+
+- (DOMNode *)getBlockquoteTagNode
+{
+    MHLog(@"No of child nodes: %d", dhc.length);
+    for (int i=0; i < dhc.length; i++)
+    {
+        if ([[[dhc item:i] nodeName] isEqualToString:TAG_BLOCKQUOTE])
+        {
+            MHLog(@"getBlockquoteTagNode:: %@ Node found at %d", TAG_BLOCKQUOTE, i);
+            return [dhc item:i];
+        }
+    }
+
+    return nil;
+}
+
 - (BOOL)isTagPresent:(NSString *)tagName
 {
     BOOL tag = FALSE;

diff --git a/ReplyWithHeader/Resources/en.lproj/MailHeader-Info.plist b/ReplyWithHeader/Resources/en.lproj/MailHeader-Info.plist
@@ -19,11 +19,11 @@
 	<key>CFBundlePackageType</key>
 	<string>BNDL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>4.6</string>
+	<string>4.7</string>
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>4.6</string>
+	<string>4.7</string>
 	<key>LSMinimumSystemVersion</key>
 	<string>${MACOSX_DEPLOYMENT_TARGET}</string>
 	<key>MHAppCastURL</key>