From 6b376ec37866214b42d8ae78003447b136e165b5 Mon Sep 17 00:00:00 2001 From: Jeffrey Tse Date: Fri, 9 Aug 2024 21:04:27 +0800 Subject: [PATCH] fix: deprecation warning for division in scss Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div($header-height, 1.5) or calc($header-height / 1.5) More info and automated migrator: https://sass-lang.com/d/slash-div --- _sass/misc/article-menu.scss | 2 +- _sass/yat.scss | 6 ++++++ _sass/yat/_base.scss | 6 +++--- _sass/yat/_layout.scss | 4 ++-- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/_sass/misc/article-menu.scss b/_sass/misc/article-menu.scss index d6271386de2..ef8b651fe84 100644 --- a/_sass/misc/article-menu.scss +++ b/_sass/misc/article-menu.scss @@ -16,7 +16,7 @@ .post-menu-content { ul { border-left: 1px solid #e9ecef; - $indent: #{$base-font-size / 4}; + $indent: math.div($base-font-size, 4); $active-bgcolor: #ecebec; @for $i from 2 to 7 { diff --git a/_sass/yat.scss b/_sass/yat.scss index b21549db8cf..c0d54504ece 100644 --- a/_sass/yat.scss +++ b/_sass/yat.scss @@ -1,5 +1,11 @@ @charset "utf-8"; +// Deprecation Warning: Using / for division outside of calc() is deprecated +// and will be removed in Dart Sass 2.0.0. +// Recommendation: math.div($header-height, 1.5) or calc($header-height / 1.5) +// More info and automated migrator: https://sass-lang.com/d/slash-div +@use 'sass:math'; + // Define defaults for each variable. $base-font-family: Helvetica Neue, Helvetica, Arial, sans-serif, !default; diff --git a/_sass/yat/_base.scss b/_sass/yat/_base.scss index b7283bfeb10..c933a8b8748 100644 --- a/_sass/yat/_base.scss +++ b/_sass/yat/_base.scss @@ -42,7 +42,7 @@ h1, h2, h3, h4, h5, h6, p, blockquote, pre, ul, ol, dl, figure, %vertical-rhythm { - margin-bottom: #{$spacing-unit / 2}; + margin-bottom: math.div($spacing-unit, 2); } @@ -128,7 +128,7 @@ a { blockquote { color: $grey-color; border-left: 4px solid $grey-color-light; - padding-left: #{$spacing-unit / 2}; + padding-left: math.div($spacing-unit, 2); @include relative-font-size(1.125); letter-spacing: -1px; font-style: italic; @@ -222,7 +222,7 @@ table { } th, td { - padding: #{$spacing-unit / 3} #{$spacing-unit / 2}; + padding: math.div($spacing-unit, 3) math.div($spacing-unit, 2); } th { diff --git a/_sass/yat/_layout.scss b/_sass/yat/_layout.scss index 97980a5d5ba..deda26871b2 100644 --- a/_sass/yat/_layout.scss +++ b/_sass/yat/_layout.scss @@ -107,7 +107,7 @@ html { .site-favicon { display: inline-block; - height: #{$header-height / 1.5}; + height: math.div($header-height, 1.5); margin-right: 5px; } } @@ -695,7 +695,7 @@ html { } @include media-query($on-palm) { - height: #{$banner-height / 1.5}; + height: math.div($banner-height, 1.5); } }