Select specific columns in getData() #138
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: modules/formulize/include/functions.php
|
A clean approach to this long standing nice-to-have feature. But we have always held off because of the presumption in many cases that all fields are available in datasets. This could be implemented only for situations where columns are specified in the list? And we won't get in trouble for missing any? Worth keeping around as a source to consult if/when this issue becomes top of mind again. |
jegelstaff
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍
@jegelstaff This PR is good to review. For some lines of code, I don't know why the indentation looks weird on github, the indentation does look fine locally.