-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Primary Relationship #544
base: master
Are you sure you want to change the base?
Primary Relationship #544
Conversation
This needs to handle empty/new systems, where there are no forms, no connections. We should setup the Primary Relationship, with no links, as part of the install. |
Done. Simply always created on loading admin page. Formal DB update not required. |
|
Stretch goals:
Key thing is this would allow for more obvious one to one connection. But the utility of one to one is not obvious/easily surfaced in Formulize right now, so keeping it in existing relationship UI would be OK. Make this an alternate sort/display order for the main form list. |
@@ -96,8 +96,8 @@ function addlink($form1_id, $form2_id, $relationship_id) { | |||
|
|||
// write the link to the links table | |||
$writelink = "INSERT INTO " . $xoopsDB->prefix("formulize_framework_links") . | |||
" (fl_frame_id, fl_form1_id, fl_form2_id, fl_key1, fl_key2, fl_relationship, fl_unified_display, fl_unified_delete, fl_common_value)". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs reverting, we need the explicit value in the DB at all times, even though we're moving ahead with everything always being this way, and not worrying about the value, we want the data to be clean. (?) or have we/can we delete the field from the DB entirely and remove all references to it??
c80d5c3
to
f3b4626
Compare
@@ -112,7 +111,7 @@ function patch40() { | |||
} | |||
} | |||
|
|||
if (!$needsPatch AND !file_exists(XOOPS_ROOT_PATH.'/modules/formulize/custom_code') AND (!isset($_GET['op']) OR ($_GET['op'] != 'patch40' AND $_GET['op'] != 'patchDB'))) { | |||
if (!$needsPatch AND primaryRelationshipExists() AND !file_exists(XOOPS_ROOT_PATH.'/modules/formulize/custom_code') AND (!isset($_GET['op']) OR ($_GET['op'] != 'patch40' AND $_GET['op'] != 'patchDB'))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make the custom code detection smarter... if code folder has only one file, and there are code features to convert... needs to be its own function :(
bb894a9
to
c0de2e7
Compare
…on before screens existed)
c0de2e7
to
a24cae3
Compare
See related issue(s)