Video Player Manager Refactor #1203
Draft
+6,310
−8,201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Out of curiosity, will part of this refactor include the TODO to move the playback reporting logic? I only ask because Native Player playback reporting seems to be hit or miss. Particularly when the app is closed instead of closing the player more gracefully in-app. I was going to look at it but I can hold off if that's an area you are going to be interacting with. |
|
Yes, my intention is to fix the playback reporting and some other discrepancies between the players with this as well. |
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was originally just implementing the now playable solution but I was discontent with
VideoPlayerManagerand had the intention to refactor it anyways, so I'm just doing that now.Very much copying solution from Apple sample app. These APIs are archaic and this is just the easiest.