Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overide gitLabCommitStatusStep to use it for setting pending status #967

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

xmass
Copy link

@xmass xmass commented Sep 4, 2019

Before submitting a pull request, please make sure you read the instructions in the "Contribution to the Plugin" section in the README.

(if you read the above instructions, remove the paragraph and start describing the pull request)

@markjacksonfishing
Copy link
Contributor

@xmass Is this still valid? I see a lot of work here and want to make sure it is adequately tracked
Is there an associated Github issue with this PR? What about a Jenkins jira? If so, can you link them? If not, can you open them and note this PR?
Thank you for that.
I am coming onboard as a maintainer and link to make sure we keep as much details across the Jenkins spectrum as well.
Thanks again :-)

@markjacksonfishing
Copy link
Contributor

Going to need to fix the ci build job

@xmass
Copy link
Author

xmass commented Oct 8, 2019

The goal was to use it instead of gitlabBuilds to set pending status to git defining git repository and commit parameters which the gitLabBuilds doesn't have. To modify gitLabCommitStatus was easier for me.
The problem I'm trying to adders here is when you start the pipeline the gitLabBuilds might not have the correct information about the git repository and which commit shall be used and often it confuses it with git repository of shared library. This solution I would call as workaround to missing functionality of gitlabBuilds and should be inherited by someone who understands better the code of gitLabBuilds and add the option to have possibility to set the git repository and commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants