Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Road to version 9.0: update to go 1.21 and operator-sdk 1.35 #954

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

[WIP] Road to version 9.0: update to go 1.21 and operator-sdk 1.35 #954

wants to merge 32 commits into from

Conversation

brokenpip3
Copy link
Collaborator

No description provided.

This was referenced Jan 7, 2024
Closed
Closed
Closed
@brokenpip3 brokenpip3 self-assigned this Feb 4, 2024
brokenpip3 and others added 18 commits February 21, 2024 00:11
@brokenpip3
feat: add flake support for both develop and build
8a886fa
@brokenpip3
chore: update jenkins lts version
ceb971e
@brokenpip3
chore: update seed job base image to use java17 by default
d48603c
@brokenpip3
chore: update plugins
8fca790
@brokenpip3
fix tests
dc18d74
@brokenpip3
fix tests, add wget and helm-docs
3d02d4b
@dependabot @brokenpip3
build(deps): bump the actions group with 9 updates
95b3cf5 
Bumps the actions group with 9 updates:

| Package | From | To |
| --- | --- | --- |
| [actions/checkout](https://github.com/actions/checkout) | `3` | `4` |
| [codespell-project/actions-codespell](https://github.com/codespell-project/actions-codespell) | `1` | `2` |
| [actions/setup-node](https://github.com/actions/setup-node) | `1` | `4` |
| [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) | `5` | `6` |
| [actions/stale](https://github.com/actions/stale) | `8` | `9` |
| [actions/setup-go](https://github.com/actions/setup-go) | `2` | `5` |
| [brokenpip3/setup-bats-libs](https://github.com/brokenpip3/setup-bats-libs) | `0.1.0` | `1.5.2` |
| [helm/kind-action](https://github.com/helm/kind-action) | `1.5.0` | `1.9.0` |
| [docker/login-action](https://github.com/docker/login-action) | `2` | `3` |


Updates `actions/checkout` from 3 to 4
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

Updates `codespell-project/actions-codespell` from 1 to 2
- [Release notes](https://github.com/codespell-project/actions-codespell/releases)
- [Commits](codespell-project/actions-codespell@v1...v2)

Updates `actions/setup-node` from 1 to 4
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v1...v4)

Updates `peter-evans/create-pull-request` from 5 to 6
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v5...v6)

Updates `actions/stale` from 8 to 9
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v8...v9)

Updates `actions/setup-go` from 2 to 5
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v2...v5)

Updates `brokenpip3/setup-bats-libs` from 0.1.0 to 1.5.2
- [Release notes](https://github.com/brokenpip3/setup-bats-libs/releases)
- [Commits](brokenpip3/setup-bats-libs@0.1.0...1.5.2)

Updates `helm/kind-action` from 1.5.0 to 1.9.0
- [Release notes](https://github.com/helm/kind-action/releases)
- [Commits](helm/kind-action@v1.5.0...v1.9.0)

Updates `docker/login-action` from 2 to 3
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: codespell-project/actions-codespell
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: brokenpip3/setup-bats-libs
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
- dependency-name: helm/kind-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
@brokenpip3
chore: use official bats core action
76d27c6
@brokenpip3
chore: update to jenkins 2.440.1-lts
ca46f35
@brokenpip3
add debug
5e7877d
@brokenpip3
fix debug regex
b729386
@brokenpip3
fix e2e test
7a42336
@brokenpip3
more time while recreating the pod
206c901
@brokenpip3
Merge remote-tracking branch 'origin/master' into version-9.0
e7dcbb6
@brokenpip3
Merge remote-tracking branch 'origin/2024-02-update' into version-9.0
7c1c5a9
@brokenpip3
fixup!
8eac469
@brokenpip3
migrate to operator version 1.33
6ad8652
@brokenpip3
update devcontainer
22096ba
@brokenpip3 brokenpip3 changed the title [WIP] Road to version 9.0: update to go 1.20 and operator-sdk 1.28 [WIP] Road to version 9.0: update to go 1.20 and operator-sdk 1.33 Feb 23, 2024
@brokenpip3 brokenpip3 added this to the 0.9 milestone Apr 19, 2024
@brokenpip3 brokenpip3 mentioned this pull request Jun 3, 2024
Merged
3 tasks
@github-actions github-actions bot added the stale label Jun 19, 2024
@github-actions github-actions bot closed this Jun 27, 2024
@brokenpip3 brokenpip3 reopened this Jun 29, 2024
@brokenpip3 brokenpip3 changed the title [WIP] Road to version 9.0: update to go 1.20 and operator-sdk 1.33 [WIP] Road to version 9.0: update to go 1.21 and operator-sdk 1.35 Jul 19, 2024
@brokenpip3
Copy link
Collaborator Author

@ansh-devs hi 👋

thanks for stepping in 🎉 since I don't have time for this in the following weeks.
I fixed all the conflict, merged master and starting fixing the golang-ci linter warnings and some of code problems after the golang and library update.

Feel free to open another branch and work on top of this one :)

My suggestion is to start from fixing the build and then the ci linter warnings.
Let me know if you want to work on this in the following days, in case we can also have a chat in gitter if you have any doubts :)

@ansh-devs
Copy link

ansh-devs commented Jul 19, 2024 •
edited
Loading

@ansh-devs hi 👋

thanks for stepping in 🎉 since I don't have time for this in the following weeks. I fixed all the conflict, merged master and starting fixing the golang-ci linter warnings and some of code problems after the golang and library update.

Feel free to open another branch and work on top of this one :)

My suggestion is to start from fixing the build and then the ci linter warnings. Let me know if you want to work on this in the following days, in case we can also have a chat in gitter if you have any doubts :)

@brokenpip3 Ok, I will continue with the refactoring 🛠️ taking this as the base can you assign me as well in this !

ansh-devs added a commit to ansh-devs/kubernetes-operator that referenced this pull request Jul 21, 2024
@ansh-devs
fix: tests, golangci
404c5e0 
*Changes*

- Continuation WIP of  jenkinsci#954
- Updated Go Version to - v1.22
- Updated Mocks for `pkg/controller/jenkins/client/jenkins.go` to support new changes
- Updated package level tests
- refactored code to adapt `context` API
- Updated dependencies

*Pending*

- [] make E2E & HELM tests compatible to new changes
@ansh-devs
Copy link

ansh-devs commented Jul 21, 2024 •
edited
Loading

Hi @brokenpip3, I have fixed the breaking changes also updated to go version to 1.22.

Changes -

  • Updated Go version to - v1.22
  • Updated Mocks for pkg/controller/jenkins/client/jenkins.go to support new changes
  • Refactored code to adapt Context API
  • Refactored existing code to satisfy golangci linter
  • Above changes has fixed all the build errors

Next/Upcoming -

  • Fixing the E2E and HELM test

@ansh-devs
Copy link

ansh-devs commented Jul 22, 2024 •
edited
Loading

@brokenpip3 how can I join the Slack workspace

@brokenpip3
Copy link
Collaborator Author

Hi @brokenpip3, I have fixed the breaking changes also updated to go version to 1.22.

Changes -

Great great progress! 👏
Thanks for taking care of this part :)

I saw that you are working on your fork, could you please open a PR against this branch? You can just open a normal PR but instead of targeting master you can target this branch: version-9.0.
I'm asking because for me will be much easier to help you in case of questions and to start reviewing the code :)

@brokenpip3 how can I join the Slack workspace

There is no slack workplace, you can join the matrix room from any client you want, gitter for instance.
But I saw you already joned it so we can continue the discussion there if you like :)
Or you can write me an email here <mygithubusername>[at]gmail[dot].com

@ansh-devs
Copy link

@brokenpip3 Refer this - #1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brokenpip3 brokenpip3

Labels
not-stale
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@brokenpip3 @ansh-devs