-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of the GrafanaLogsBackendWithJenkinsVisualization #865
First version of the GrafanaLogsBackendWithJenkinsVisualization #865
Conversation
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
…quest-parameters` Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
# Conflicts: # pom.xml # src/main/java/io/jenkins/plugins/opentelemetry/OpenTelemetrySdkProvider.java
...enkins/plugins/opentelemetry/backend/grafana/GrafanaLogsBackendWithJenkinsVisualization.java
Fixed
Show fixed
Hide fixed
@Extension(ordinal = 50) | ||
public static class DescriptorImpl extends GrafanaLogsBackend.DescriptorImpl { | ||
|
||
public FormValidation doCheckLokiUrl(@QueryParameter("lokiUrl") String url) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation Warning
...enkins/plugins/opentelemetry/backend/grafana/GrafanaLogsBackendWithJenkinsVisualization.java
Fixed
Show fixed
Hide fixed
@Extension(ordinal = 50) | ||
public static class DescriptorImpl extends GrafanaLogsBackend.DescriptorImpl { | ||
|
||
public FormValidation doCheckLokiUrl(@QueryParameter("lokiUrl") String url) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check Warning
The merge will trigger a release, so it is better to merge on Monday. |
Signed-off-by: Cyrille Le Clerc <cyrille.leclerc@grafana.com>
A last review please @kuisathaverat 👼 a few security improvements |
First version of the GrafanaLogsBackendWithJenkinsVisualization
Testing done
Submitter checklist