fix: SpotBugs: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE Spotbug

jenkinsci · Dec 5, 2024 · 99b6f84 · 99b6f84
1 parent 68362fe
commit 99b6f84
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/main/java/io/jenkins/plugins/restlistparam/logic/RestValueService.java b/src/main/java/io/jenkins/plugins/restlistparam/logic/RestValueService.java
@@ -144,7 +144,11 @@ private static ResultContainer<String> getValueStringFromRestEndpoint(final Stri
     try (Response response = client.newCall(request).execute()) {
       int statusCode = response.code();
       if (statusCode < 400) {
-        container.setValue(response.body() != null ? response.body().string() : "");
+        String value = "";
+        okhttp3.ResponseBody body = response.body();
+        if (body != null)
+          value = body.string();
+        container.setValue(value);
       }
       else if (statusCode < 500) {
         log.warning(Messages.RLP_RestValueService_warn_ReqClientErr(statusCode));