-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable CI for Windows #115
Conversation
Despite adding windows as list of configuration to test, it seems that jenkins pipeline only runs linux configuration. EDIT: seems like it's checking some permissions related to the user. What should be added to get access?
|
I re-ran the build for you and I can see a bunch of test failures. I've created an origin branch which should allow you to experiment by PR'ing to the origin branch instead, although you won't be able to make any |
Thanks @timja. For now, I'm trying to understand in which environment windows job is running. I expected to see some docker images, but it seems it's not the case (see log: https://ci.jenkins.io/job/jenkinsci-libraries/job/winp/job/PR-115/3/console). Do you have public documentation on how aci-maven-17-windows-3pn09 is setup? |
Some documentation is here: The container used is:
I believe built from: https://github.com/jenkins-infra/docker-inbound-agents/blob/main/maven/jdk17/Dockerfile.nanoserver |
Thanks. I'll try to execute this on my local windows machine, and add a VS install step using mvn. |
In short, I identified that VS can't be installed on nanoserver windows images. |
I started a new build with the Jenkinsfile recommended by @dduportal |
Thanks, I'll open a new PR for enabling CI + changes needed. |
As discussed on #112, this PR will try to enable CI for windows, by using existing jenkins infrastructure (https://ci.jenkins.io/job/jenkinsci-libraries/job/winp/job/master/).
Windows platform was explicitely disabled because native binaries are not available.
This PR will reproduce this, and fix this in a clean way.
Since it's hard to reproduce Jenkins pipeline out of official infra, this PR will serve as a playground.