Use official Jenkins CI to build and test winp
#116
Conversation
- extract build-native.cmd - build.cmd: catch errors from build-native.cmd - build.cmd: fix path to artifacts - build.cmd: do not update version in pom.xml
Some error code were found on windows-arm64 machine, and we now ignore a code for specific protected processes. The unit test concerned lists all processes on the machine, which makes it hard to reproduce and reliable.
Visual Studio 2017 is not supported anymore.
Official Jenkins CI will perform compilation from now on.
This environment has access to VS 2019.
|
New Jenkinsfile should be validated, as C++ build is now done as part of maven build, and thus, requires windows. |
There was a problem hiding this comment.
Thanks for the PR! This is much appreciated, and a huge contribution to this project. Kudos!
The next step after this PR is to create a PR that enables JEP-229 CD for this repository, using GitHub Actions as is standard for CD in the Jenkins project. The CD portion should largely follow https://www.jenkins.io/doc/developer/publishing/releasing-cd/ but may be slightly more involved in that it needs to run on a Windows system in GitHub Actions rather than a Linux system in GitHub Actions as the instructions currently describe.
| * Windows XP SP2 and above | ||
| * Windows Server 2003 and above | ||
| * Windows 10 and above | ||
| * Windows Server 2019 and above |
There was a problem hiding this comment.
BTW do you know if this is dropping support for Windows Server 2016? I am definitely OK with dropping support for Windows Server 2012, since its extended end date of October 2023 has already passed, but I wonder if there may be Jenkins users still using Windows Server 2016. Jenkins users might still be using Windows Server 2016 since although its mainstream end date was in January of 2022, its extended end date isn't until 2027. Keeping support for it would be ideal if it isn't prohibitively costly, but dropping support wouldn't be the end of the world — after all, we dropped support for CentOS 7 — but this would need to be communicated broadly to existing users (in the changelog and upgrade guide) and might be worth highlighting on the developer list in case others have a strong opinion about this.
There was a problem hiding this comment.
I am going to go ahead with this PR, but I am still hoping for a response to this comment, after which we can update the Release Notes/Upgrade Guide if necessary.
There was a problem hiding this comment.
I looked for information about which windows version was officially supported with default sdk for VS 2019, and found only Windows 10 and Server 2019. After all, Microsoft is trying to kill previous versions and force people to migrate, so we should not expect more than this.
Regarding our dependencies and windows functions used, I think it's pretty safe to say that Server 2016 should keep supported, as we don't use any "recent" API function.
Finally, people staying on a previous version of Windows probably prefer to stay on a previous version of Jenkins as well (it's more "stable" you know), so I would not worry too much about this.
This reverts commit f0d4514.
basil
changed the title
winp
|
Many thanks again! I have filed #117 to cover the CD work that is needed before we'll be able to release this. |
|
Thanks @basil for fixing the last bits and merge this PR. I'll take a look to CD part, should be easy as the same code will compile cleanly on GitHub Actions thanks to previous versions. |
|
Caused #119 |
This PR is the answer to he discussion we had on arm64 support (#112).
Basically, it was identified that the current situation was not satisfying, and that code should be built and tested directly on CI infrastructure. This is what we do here.
Jenkins infra team added Visual Studio 2019 to official runners (jenkins-infra/helpdesk#4047), which was a prerequisite to make this possible.
This PR does not add support for any new architecture, it just updates minimal Visual Studio version required. In more, we delete committed binaries on this repository, and integrate c++ build with maven.
Fixes #40