Update WinProcess.java

[senderic]

Using getCommandLine() in the toString() function to ensure that the commandline String variable is set. The getCommandLine() function will internally have it parsed if it is currently null.

[oleg-nenashev]

It was intentional to avoid excessive load when the values are not available. What is a use-case for it?

[senderic]

When I tried to print the contents of my WinProcess object, I was getting a null at the end of the toString. I realized it was because the toString function relies of the variable being set, which only happens in the getter, not the constructor. So alternatively I think having the constructor create the object is fine as well.

[oleg-nenashev]

Would if we replace null by a more explicit string like: "cmd line arguments have not been read yet" or so?

[senderic]

That certainly is better than null. I do wonder why would there be concern about excessive load for this parsing event in the toString. I'd think the user of your API would expect the command to be available to them. I did, which is what lead me to looking at the source code and making this pull request.

[oleg-nenashev]

Retrieval of process command line is pretty heavy, because it has to read the Process headers.
toString() method was being used externally in logging (e.g. in https://github.com/jenkinsci/jenkins/blob/e18df1ffd3d53fe12f6dca75a264b3550d6e8e5f/core/src/main/java/hudson/util/ProcessTree.java before I cleaned it up), and I can imagine other such cases in external usages.

If API users need to get command line, there is a WinProcess#getCommandLine() method for it.

Anyway, I will update the string to make the message more clear

[oleg-nenashev]

Fix applied in bd2fa87