Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultStepContext.get should directly handle certain types #252

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 7, 2024

We do not expect CpsStepContext.doGet to ever return non-null for these so why even ask? May solve test flakes introduced by jenkinsci/pipeline-input-step-plugin#145.

Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me and we have considered it previously. I think it is worth running PCT against it first though to check for any unexpected consequences.

@dwnusbaum
Copy link
Member

Oh also looking at a local patch I had for this, it might be worth updating the doGet Javadoc with something like this:

     * <p>Note that some basic types are handled directly by {@link #get} and cannot be overridden, such as {@link Run},
     * {@link Job}, {@link FlowExecution}, and {@link FlowNode}.

@jglick jglick marked this pull request as draft April 15, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants