Fix problem with ZIP paths on Windows. #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 74.82% 74.84% +0.01%
==========================================
Files 25 25
Lines 4116 4118 +2
==========================================
+ Hits 3080 3082 +2
Misses 1036 1036 ☔ View full report in Codecov by Sentry. |
|
Thanks for the fix! https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.as_posix |
Replace `str.join` with `Path.as_posix`.
|
@speleo3 can you please review again with this change? |
speleo3
reviewed
Dec 31, 2023
| continue | ||
| zf = zipfile.ZipFile(p) | ||
| stream = zf.open(str(input_file.relative_to(p))) | ||
| path_string = Path.as_posix(input_file.relative_to(p)) |
There was a problem hiding this comment.
Same as input_file.relative_to(p).as_posix()
speleo3
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181.