refactor: simplify cellar tests

jeremyckahn · May 20, 2024 · 85aa293 · 85aa293
1 parent 5e444bb
commit 85aa293
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 14 deletions.
diff --git a/src/services/cellar.js b/src/services/cellar.js
@@ -17,11 +17,7 @@ export class CellarService {
   /**
    * @private
    */
-  _uuid
-
-  constructor(uuidFactory = uuid) {
-    this._uuid = uuidFactory
-  }
+  _uuid = uuid
 
   getItemInstancesInCellar = memoize(
     /**

diff --git a/src/services/cellar.test.js b/src/services/cellar.test.js
@@ -3,21 +3,19 @@ import { pumpkin } from '../data/crops'
 
 import { getYeastRequiredForWine } from '../utils/getYeastRequiredForWine'
 
-import { CellarService } from './cellar'
+import { cellarService } from './cellar'
 
 const mockUuid = 'abc123'
 
-const mockUuidFactory = () => {
-  return mockUuid
-}
-
-// @ts-expect-error
-const stubCellarService = new CellarService(mockUuidFactory)
+beforeEach(() => {
+  // @ts-expect-error
+  jest.spyOn(cellarService, '_uuid').mockReturnValue(mockUuid)
+})
 
 describe('CellarService', () => {
   describe('generateKeg', () => {
     test('generates a fermented crop keg', () => {
-      const keg = stubCellarService.generateKeg(pumpkin)
+      const keg = cellarService.generateKeg(pumpkin)
 
       expect(keg).toEqual({
         daysUntilMature: pumpkin.daysToFerment,
@@ -27,7 +25,7 @@ describe('CellarService', () => {
     })
 
     test('generates a wine keg', () => {
-      const keg = stubCellarService.generateKeg(wineChardonnay)
+      const keg = cellarService.generateKeg(wineChardonnay)
 
       expect(keg).toEqual({
         daysUntilMature: getYeastRequiredForWine(wineChardonnay.variety),