Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Improve QuantityInput spacing #489

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

jeremyckahn
Copy link
Owner

@jeremyckahn jeremyckahn commented Apr 5, 2024

What this PR does

This PR improves a regression that I believe was introduced by #470. It improves the display of the QuantityInput component.

How this change can be validated

Ensure that quantity input looks and works correctly throughout the game.

Additional information

Before:

Screenshot of before change

After:

Screenshot of after change

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
farmhand ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 11:29pm

Copy link
Collaborator

@lstebner lstebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on mobile and desktop, code looks good; nice work!

@jeremyckahn jeremyckahn merged commit 18a1adb into develop Apr 7, 2024
6 checks passed
@jeremyckahn jeremyckahn deleted the feature/improve-quantity-input-display branch April 7, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants