Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forest): Keep Forest unlock notification behind feature flag #502

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

jeremyckahn
Copy link
Owner

What this PR does

This PR fixes an issue that was discovered by a player: The Forest unlock notification was being shown in Production. This feature is still in development, so this notification should be withheld by a feature flag.

This PR also improves the experience gauge tooltip by showing an alternate label when there is one point left to reach the next level.

How this change can be validated

You can use this test save to aid in validation.

  • With the FOREST feature flag disabled (default behavior for preview deployment), verify that the forest unlock notification does not appear when the player reaches level 15
    • In the test save linked above, this can be done by selling the Carrot that is in the inventory
  • With the FOREST feature flag enabled (add ?enable_FOREST=1 to the preview deployment URL), verify that the forest unlock notification does appear when the player reaches level 15

  • When there is one experience point left to reach the next level, verify that the experience gauge tooltip reads Just 1 more experience point needed to reach level XX!
  • When there is more than one experience point needed to reach the next level, verify that the experience gauge tooltip reads XX more experience points needed to reach level YY

@jeremyckahn jeremyckahn added bug Something isn't working enhancement New feature or request labels Jun 15, 2024
Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
farmhand ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 3:09pm

@jeremyckahn jeremyckahn merged commit 61a9931 into develop Jun 17, 2024
6 checks passed
@jeremyckahn jeremyckahn deleted the bugfix/forest-notification branch June 17, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants