Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS XRay #93

Open
seawatts opened this issue Jun 2, 2021 · 1 comment
Open

Support AWS XRay #93

seawatts opened this issue Jun 2, 2021 · 1 comment

Comments

@seawatts
Copy link

seawatts commented Jun 2, 2021

It would be nice to be able to pass in our own instance of the AWS.RDS client so that we can wrap it with the aws-xray-sdk

You can find the docs for wrapping AWS clients here: https://www.npmjs.com/package/aws-xray-sdk-core#user-content-capture-all-outgoing-aws-requests
@seawatts seawatts mentioned this issue Jun 2, 2021
Open
@rpawlaszek
Copy link

Hi @seawatts @jeremydaly

I created a PR to address this issue. It not only enables the introduction of X-Ray, but decouples the library from any, specific aws-sdk version so the user can choose which version of the library they want to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seawatts @rpawlaszek