Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Band Effect: Filter (pre-drive) #36

Open
Phazmaonline opened this issue Jul 27, 2022 · 8 comments
Open

[Feature Request] Band Effect: Filter (pre-drive) #36

Phazmaonline opened this issue Jul 27, 2022 · 8 comments

Comments

@Phazmaonline
Copy link

I think it could be a cool idea to have a Filter also as Band Effect, with the possibility to filter before distortion. Having a resonant filter going into the distortion and automating the cutoff frequency can give a very nice sweeping effect, specially on basslines. (A tempo-synced LFO to control it would be the cherry on top but maybe that would go a bit too far for what you intended Fire to be.)

@jerryuhoo
Copy link
Owner

Do you mean a global filter before distortion or a filter for each band?

               -> band 1 distortion ->
a). pre-filter -> band 2 distortion -> post-filter
               -> band 3 distortion ->

    pre-filter ->  band 1 distortion ->
b). pre-filter ->  band 2 distortion -> post-filter
    pre-filter ->  band 3 distortion ->

@jerryuhoo
Copy link
Owner

(A tempo-synced LFO to control it would be the cherry on top but maybe that would go a bit too far for what you intended Fire to be.)

Designing a tempo-synced LFO to control is very complicated, and I don't think I can make that with my current skills. 😂

@Phazmaonline
Copy link
Author

Originally, for flexibility, I thought of your suggestion "b" (filter for each band).
But now that you mention it, actually I think suggestion "a" (global pre-dist filter) is probably easier to control and get useful results with. It would certainly be sufficient for my kind of use.

@jerryuhoo
Copy link
Owner

Yeah, I also think "a" is easier to design, I would use "a".

@Phazmaonline
Copy link
Author

Ok, if you manage to add option "a" that would be very cool :)

@jerryuhoo
Copy link
Owner

I'm kinda busy these days so this update will not be available for v1.0.0 and will appear in the next version.

@Phazmaonline
Copy link
Author

No worries, thanks meanwhile for the other implementations! Btw I tested v1.0.0 and commented my thoughts on the other 2 closed issues (#35 and #37 ).

@IsaakCode
Copy link

Yes, one global pre-saturation stage filter would be perfect (similar to the current implementation of the post-saturation EQ, just pre).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants