Merge pull request #47 from jessedoyle/ameba

Static Analysis

.gitignore

@@ -3,3 +3,6 @@
 .build/
 src/.build
 /doc/
+/lib
+/bin
+/shard.lock

.travis.yml

@@ -1,5 +1,9 @@
 language: crystal
 before_install: make libduktape
-script: make spec
+install:
+  - shards install
+script:
+  - make spec
+  - bin/ameba
 sudo: false
-email: false
+email: false

CHANGELOG.md

@@ -1,3 +1,8 @@
+# v0.15.1 - Nov 7, 2018
+
+- Add [ameba](https://github.com/veelenga/ameba) as a development dependency for static analysis.
+- Fix `ameba` lint exceptions consisting of unused variable definitions and block variables.
+
 # v0.15.0 - Aug 14, 2018
 
 - Update Duktape version to `2.3.0`.

README.md

@@ -18,7 +18,7 @@ version: 1.0.0 # your project's version
 dependencies:
   duktape:
     github: jessedoyle/duktape.cr
-    version: ~> 0.15.0
+    version: ~> 0.15.1
 ```
 
 then execute:

shard.yml

@@ -1,10 +1,15 @@
 name: duktape
-version: 0.15.0
+version: 0.15.1
 
 authors:
   - Jesse Doyle <jdoyle@ualberta.ca>
 
 scripts:
   postinstall: "make -C ext clean libduktape"
 
+development_dependencies:
+  ameba:
+    github: veelenga/ameba
+    version: 0.8.1
+
 license: MIT

spec/duktape/api/heap_spec.cr

@@ -23,7 +23,7 @@ describe Duktape do
 
   describe "create_heap" do
     it "should create a heap with a custom fatal func" do
-      heap = Duktape.create_heap do |ctx, msg|
+      heap = Duktape.create_heap do
         num = 3 + 5
         raise Exception.new num.to_s
       end

spec/duktape/api/thread_spec.cr

@@ -6,7 +6,7 @@ describe Duktape::API::Thread do
       ctx = Duktape::Context.new
       ctx.push_global_proc("test") do |ptr|
         env = Duktape::Context.new ptr
-        state = env.suspend
+        env.suspend
         # as the engine is suspended, we should not evaluate 'true'
         env.eval("true")
         env.get_boolean(-1).should be_false

spec/duktape/sandbox_spec.cr

@@ -14,7 +14,7 @@ describe Duktape::Sandbox do
     context "with timeout" do
       it "should raise if timeout < 100" do
         expect_raises ArgumentError, /> 100ms/ do
-          sbx = Duktape::Sandbox.new 99
+          Duktape::Sandbox.new 99
         end
       end
 

src/duktape/api/heap.cr

@@ -20,14 +20,14 @@ module Duktape
   end
 
   def self.create_heap_default
-    create_heap do |udata, msg|
+    create_heap do |_, msg|
       str = String.new msg
       raise Duktape::InternalError.new str
     end
   end
 
   def self.create_heap_udata(udata : Void*)
-    create_heap(udata) do |udata, msg|
+    create_heap(udata) do |_, msg|
       str = String.new msg
       raise Duktape::InternalError.new str
     end

src/duktape/version.cr

@@ -16,7 +16,7 @@ module Duktape
   module VERSION
     MAJOR =  0
     MINOR = 15
-    TINY  =  0
+    TINY  =  1
     PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join "."