Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Refactor #26

Merged
merged 18 commits into from
Aug 27, 2024
Merged

Compile Refactor #26

merged 18 commits into from
Aug 27, 2024

Conversation

jessegrabowski
Copy link
Owner

@jessegrabowski jessegrabowski commented Aug 21, 2024

Refactor the initial building of the model object to make the code a bit more clear.

  • Divide responsibility for parsing and compiling
  • Move each backend's compilation logic to its own file

Also installs versioneer for setting up a release pipeline

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 75.14170% with 307 lines in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (51096e4) to head (fa429ae).
Report is 3 commits behind head on main.

Files Patch % Lines
cge_modeling/_version.py 42.61% 206 Missing ⚠️
cge_modeling/tools/sympy_tools.py 12.82% 34 Missing ⚠️
cge_modeling/base/function_wrappers.py 69.86% 22 Missing ⚠️
cge_modeling/compile/sympytensor.py 85.27% 19 Missing ⚠️
cge_modeling/compile/pytensor.py 94.26% 9 Missing ⚠️
cge_modeling/base/build.py 84.44% 7 Missing ⚠️
cge_modeling/base/cge.py 76.66% 7 Missing ⚠️
cge_modeling/base/utilities.py 85.71% 1 Missing ⚠️
cge_modeling/compile/numba.py 98.91% 1 Missing ⚠️
cge_modeling/compile/pytensor_tools.py 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   68.93%   68.30%   -0.63%     
==========================================
  Files          17       24       +7     
  Lines        2707     3155     +448     
==========================================
+ Hits         1866     2155     +289     
- Misses        841     1000     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessegrabowski jessegrabowski merged commit 39529d8 into main Aug 27, 2024
3 checks passed
@jessegrabowski jessegrabowski deleted the grad-cleanup branch August 27, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant