Skip to content

Commit

Permalink
Updated assembly resolve routing to handle requests for Full Names (b…
Browse files Browse the repository at this point in the history
…y comparing to name only at the moment).
  • Loading branch information
jessehouwing committed Feb 22, 2016
1 parent 58052c5 commit cdf8097
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 10 deletions.
6 changes: 3 additions & 3 deletions extension-manifest.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"manifestVersion": 1,
"id": "jessehouwing-vsts-tfvc-tasks",
"id": "jessehouwing-vsts-tfvc-tasks-TEST",
"name": "TFVC Build Tasks",
"version": "1.0.26",
"version": "1.0.29",
"publisher": "jessehouwing",
"public": true,
"public": false,
"targets": [
{
"id": "Microsoft.VisualStudio.Services"
Expand Down
7 changes: 5 additions & 2 deletions vsts-tfvc-add/TfvcAdd.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,19 @@ function Load-Assembly
}
}

$assemblyToLoad = New-Object System.Reflection.AssemblyName $name


foreach ($path in $ProbingPaths)
{
Write-Debug "Checking in $path"

$path = [System.IO.Path]::Combine($path, "$($Name).dll")
$path = [System.IO.Path]::Combine($path, "$($assemblyToLoad.Name).dll")
Write-Debug "Looking for $path"
if (Test-Path -PathType Leaf -LiteralPath $path)
{
Write-Debug "Found assembly: $path"
if ([System.Reflection.AssemblyName]::GetAssemblyName($path).Name -eq $Name)
if ([System.Reflection.AssemblyName]::GetAssemblyName($path).Name -eq $assemblyToLoad.Name)
{
Write-Debug "Loading assembly: $path"
return [System.Reflection.Assembly]::LoadFrom($path)
Expand Down
2 changes: 1 addition & 1 deletion vsts-tfvc-add/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"version": {
"Major": 1,
"Minor": 0,
"Patch": 94
"Patch": 97
},
"minimumAgentVersion": "1.83.0",
"groups": [
Expand Down
7 changes: 5 additions & 2 deletions vsts-tfvc-checkin/TfvcCheckin.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,19 @@ function Load-Assembly
}
}

$assemblyToLoad = New-Object System.Reflection.AssemblyName $name


foreach ($path in $ProbingPaths)
{
Write-Debug "Checking in $path"

$path = [System.IO.Path]::Combine($path, "$($Name).dll")
$path = [System.IO.Path]::Combine($path, "$($assemblyToLoad.Name).dll")
Write-Debug "Looking for $path"
if (Test-Path -PathType Leaf -LiteralPath $path)
{
Write-Debug "Found assembly: $path"
if ([System.Reflection.AssemblyName]::GetAssemblyName($path).Name -eq $Name)
if ([System.Reflection.AssemblyName]::GetAssemblyName($path).Name -eq $assemblyToLoad.Name)
{
Write-Debug "Loading assembly: $path"
return [System.Reflection.Assembly]::LoadFrom($path)
Expand Down
2 changes: 1 addition & 1 deletion vsts-tfvc-checkin/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"version": {
"Major": 1,
"Minor": 0,
"Patch": 125
"Patch": 128
},
"visibility": [
"Build"
Expand Down
Empty file.
Empty file.
3 changes: 2 additions & 1 deletion vsts-tfvc-tasks.sln
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio 14
VisualStudioVersion = 14.0.24720.0
VisualStudioVersion = 14.0.25008.0
MinimumVisualStudioVersion = 10.0.40219.1
Project("{F5034706-568F-408A-B7B3-4D38C6DB8A32}") = "vsts-tfvc-checkin", "vsts-tfvc-checkin\vsts-tfvc-checkin.pssproj", "{6CAFC0C6-A428-4D30-A9F9-700E829FEA51}"
EndProject
Expand All @@ -17,6 +17,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Extension", "Extension", "{
ProjectSection(SolutionItems) = preProject
extension-manifest.json = extension-manifest.json
extension\extension-overview.md = extension\extension-overview.md
readme.md = readme.md
EndProjectSection
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Images", "Images", "{ADFB1042-D16B-4621-900A-CFB227C18EA0}"
Expand Down
1 change: 1 addition & 0 deletions vsts-tfvc-tasks.vsext
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@


0 comments on commit cdf8097

Please sign in to comment.