Don't mark manual rules without Rego as missing (#77)

* Don't mark manual rules without Rego as missing Signed-off-by: wwwil <wwwil.squires@gmail.com> * Add manual rule to TestNewReport Signed-off-by: wwwil <wwwil.squires@gmail.com>
jetstack · Feb 5, 2020 · 33cfa96 · 33cfa96
1 parent 0098447
commit 33cfa96
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/pkg/reports/reports.go b/pkg/reports/reports.go
@@ -126,8 +126,10 @@ func NewReport(pm *packaging.PolicyManifest, rc *results.ResultCollection) (api.
 
 			switch {
 			case result == nil:
-				missing = true
-				missingRules = append(missingRules, rule.ID)
+				if !rule.Manual {
+					missing = true
+					missingRules = append(missingRules, rule.ID)
+				}
 			case result.IsFailureState():
 				success = false
 				violations = result.Violations

diff --git a/pkg/reports/reports_test.go b/pkg/reports/reports_test.go
@@ -245,6 +245,11 @@ func TestNewReport(t *testing.T) {
 						ID:   "b_rule",
 						Name: "My Rule B",
 					},
+					{
+						ID:     "c_rule",
+						Name:   "My Rule C",
+						Manual: true,
+					},
 				},
 			},
 		},
@@ -295,6 +300,15 @@ func TestNewReport(t *testing.T) {
 							Links:      []string{},
 							Violations: []string{"violation"},
 						},
+						api.ReportRule{
+							ID:         "c_rule",
+							Name:       "My Rule C",
+							Manual:     true,
+							Success:    false,
+							Missing:    false,
+							Links:      []string{},
+							Violations: []string{},
+						},
 					},
 				},
 			},
@@ -349,6 +363,15 @@ func TestNewReport(t *testing.T) {
 							Links:      []string{},
 							Violations: []string{},
 						},
+						api.ReportRule{
+							ID:         "c_rule",
+							Name:       "My Rule C",
+							Manual:     true,
+							Success:    false,
+							Missing:    false,
+							Links:      []string{},
+							Violations: []string{},
+						},
 					},
 				},
 			},