PR feedback

jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ErrorHandler.java

@@ -73,6 +73,7 @@ public class ErrorHandler implements Request.Handler
     boolean _showStacks = false;
     boolean _showCauses = false;
     boolean _showMessageInTitle = true;
+    int _bufferSize = -1;
     String _defaultResponseMimeType = Type.TEXT_HTML.asString();
     HttpField _cacheControl = new PreEncodedHttpField(HttpHeader.CACHE_CONTROL, "must-revalidate,no-cache,no-store");
 
@@ -196,7 +197,7 @@ else if (charsets.contains(StandardCharsets.ISO_8859_1))
                 return false;
         }
 
-        int bufferSize = getBufferSize(request);
+        int bufferSize = getBufferSize() <= 0 ? computeBufferSize(request) : getBufferSize();
         RetainableByteBuffer buffer = request.getComponents().getByteBufferPool().acquire(bufferSize, false);
 
         try
@@ -261,10 +262,10 @@ else if (charsets.contains(StandardCharsets.ISO_8859_1))
         }
     }
 
-    protected int getBufferSize(Request request)
+    protected int computeBufferSize(Request request)
     {
         int bufferSize = request.getConnectionMetaData().getHttpConfiguration().getOutputBufferSize();
-        bufferSize = Math.min(8192, bufferSize); // TODO ?
+        bufferSize = Math.min(8192, bufferSize);
         return bufferSize;
     }
 
@@ -532,6 +533,25 @@ public static Request.Handler getErrorHandler(Server server, ContextHandler cont
         return errorHandler;
     }
 
+    /**
+     * @return Buffer size for entire error response. If error page is bigger than buffer size, it will be truncated.
+     * With a -1 meaning that a heuristic will be used (e.g. min(8K, httpConfig.bufferSize))
+     */
+    @ManagedAttribute("Buffer size for entire error response")
+    public int getBufferSize()
+    {
+        return _bufferSize;
+    }
+
+    /**
+     * @param bufferSize Buffer size for entire error response. If error page is bigger than buffer size, it will be truncated.
+     * With a -1 meaning that a heuristic will be used (e.g. min(8K, httpConfig.bufferSize))
+     */
+    public void setBufferSize(int bufferSize)
+    {
+        this._bufferSize = bufferSize;
+    }
+
     public static class ErrorRequest extends Request.AttributesWrapper
     {
         private static final Set<String> ATTRIBUTES = Set.of(ERROR_MESSAGE, ERROR_EXCEPTION, ERROR_STATUS);