Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9341 - jetty-jmh testing fails due to "java.lang.AssertionError: No trie for TernaryTrie" #11427

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Feb 21, 2024

Fixed by using an enum and expression switch to avoid using string constants that may become obsolete.

…: No trie for TernaryTrie"

Fixed by using an enum and expression switch to avoid using string constants that may become obsolete.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was reported against Jetty 10.0.x, do we want to cherry-pick this back?

@joakime joakime changed the title Fixes #9341 - jetty-jmh 10.013 fails due to "java.lang.AssertionError: No trie for TernaryTrie" Fixes #9341 - jetty-jmh fails due to "java.lang.AssertionError: No trie for TernaryTrie" Feb 21, 2024
@joakime joakime changed the title Fixes #9341 - jetty-jmh fails due to "java.lang.AssertionError: No trie for TernaryTrie" Fixes #9341 - jetty-jmh testing fails due to "java.lang.AssertionError: No trie for TernaryTrie" Feb 21, 2024
@sbordet
Copy link
Contributor Author

sbordet commented Feb 21, 2024

Nah, it's just a minor correction of a benchmark that typically only we look at.

@sbordet sbordet merged commit 8fec190 into jetty-12.0.x Feb 21, 2024
8 checks passed
@sbordet sbordet deleted the fix/jetty-12/9341/trie-benchmark branch February 21, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

jetty-jmh 10.013 fails due to "java.lang.AssertionError: No trie for TernaryTrie"
2 participants