Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for HttpSession.Accessor with WebSocket #11828

Merged
merged 2 commits into from
May 27, 2024
Merged

add test for HttpSession.Accessor with WebSocket #11828

merged 2 commits into from
May 27, 2024

Conversation

lachlan-roberts
Copy link
Contributor

Add test using HttpSession.Accessor with WebSocket.

@lachlan-roberts
add test for HttpSession.Accessor with WebSocket
253eeb9 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested a review from janbartel May 22, 2024 01:40
gregw
gregw requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start, but can you add a test cases that sends a websocket message which invalidates the session and check that the session is still invalid on the next message.

@lachlan-roberts
add test for invaliding the session from WebSocket
548ed9a 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts requested a review from gregw May 22, 2024 02:19
@lachlan-roberts lachlan-roberts merged commit f7e502b into jetty-12.1.x May 27, 2024
6 of 10 checks passed
@lachlan-roberts lachlan-roberts deleted the jetty-12.1.x-websocket-HttpSessionTest branch May 27, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@janbartel janbartel Awaiting requested review from janbartel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlan-roberts @gregw