Fixed JPMS declarations. #11831
Merged
Fixed JPMS declarations. #11831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some require transitive was missing, and has been added. In other cases, making a field private (e.g. for log instances) made the warning go away. In another case, removed explicit dependency on websocket core exception, as it was not necessary. Clean up the POMs for jetty-eeN-annotations, that had unnecessary dependencies. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lorban
reviewed
May 22, 2024
Compiling the project (either Maven or IntelliJ) reports the warnings. I don't think it's testable, unless we want to be very strict and tell the compiler to fail on warnings, but I guess that would fail on a million other warnings. |
lorban
approved these changes
May 22, 2024
|
Those compiler errors are reported in Jenkins. |
olamy
approved these changes
May 22, 2024
gregw
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some require transitive was missing, and has been added.
In other cases, making a field private (e.g. for log instances) made the warning go away.
In another case, removed explicit dependency on websocket core exception, as it was not necessary.
Clean up the POMs for jetty-eeN-annotations, that had unnecessary dependencies.