Fix contains in HttpFields name set and prove random access to HttpFields via EnumMap not worth it. #11846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #11811 with javadoc and an optional random access implementation.
|
@sbordet @lachlan-roberts @lorban review please |
lorban
requested changes
Jun 6, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpFields.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/test/java/org/eclipse/jetty/http/HttpFieldsTest.java
Show resolved
Hide resolved
jetty-core/jetty-http/src/test/java/org/eclipse/jetty/http/HttpFieldsTest.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Jun 6, 2024
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/HttpFields.java
Outdated
Show resolved
Hide resolved
Fix #11811 with javadoc and an optional random access implementation.
|
I have removed the random access class, but there are some other minor fixes in this PR (for contains checks in name sets). Also some javadoc improvements and the JMH test to show that even enumMap doesn't help. |
gregw
changed the title
lorban
approved these changes
Jun 11, 2024
lachlan-roberts
approved these changes
Jun 11, 2024
sbordet
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment towards fix #11811 with regards to the extra comments received on #11823
It provides an optional random access implementation and fixes the issue that the name set returned is not case sensitive.
Another approach could be to always create the EnumMap when an immutable HttpFields is created and only do the iteration lookup on fields that are not known HttpHeaders