Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to issue #38 #43

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Related to issue #38 #43

merged 1 commit into from
Jan 23, 2024

Conversation

LuisOlivaresJ
Copy link
Collaborator

A new line of code to automatically create a new release on GutHub only if the pull request merge branch has a tag.
To test, the branch "issue_action_workflow" (from where I am opening this pull request) has a tag on it.

@LuisOlivaresJ
Copy link
Collaborator Author

LuisOlivaresJ commented Jan 22, 2024

Hi, I would like to add that we need a tag because otherwise the workflow is going to take the name of the branch (OMG_master) to name the release, and since it already exists (from the last release), we get an error. github.ref is the variable used by the workflow to get the release name that is going to be used, as can be see here. Additionally, I am considering to delete the tag named "OMG_master" to avoid confusion with the master branch name. What do you think?

Tag

@jfcabana
Copy link
Owner

Hi, I would like to add that we need a tag because otherwise the workflow is going to take the name of the branch (OMG_master) to name the release, and since it already exists (from the last release), we get an error. github.ref is the variable used by the workflow to get the release name that is going to be used, as can be see here. Additionally, I am considering to delete the tag named "OMG_master" to avoid confusion with the master branch name. What do you think?

Tag

I agree with the suggestion.

@LuisOlivaresJ
Copy link
Collaborator Author

LuisOlivaresJ commented Jan 23, 2024

can not detele the tag

I can not delete the OMG_master tag. Maybe because repository permissions.

@jfcabana
Copy link
Owner

can not detele the tag

I can not delete the OMG_master tag. Maybe because repository permissions.

I could not delete either. I could however Edit Release and change the tag to v1.6.1.

@LuisOlivaresJ
Copy link
Collaborator Author

That could be enough. Now, let's see what happens with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants