Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix poetry tests on Windows #1006

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Fix poetry tests on Windows #1006

merged 1 commit into from
Oct 22, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 22, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

  • Update Poetry dependencies to handle the following issue:
        Installing dependencies from lock file
        
        Package operations: 10 installs, 0 updates, 0 removals
        
          � Installing atomicwrites (1.4.1)
          � Installing attrs (22.1.0)
          � Installing colorama (0.4.6)
          � Installing more-itertools (9.0.0)
          � Installing packaging (22.0)
          � Installing pluggy (0.13.1)
          � Installing py (1.11.0)
          � Installing wcwidth (0.2.5)
          � Installing numpy (1.24.0)
          � Installing pytest (5.4.3)
        
          ChefBuildError
        
          Backend 'setuptools.build_meta:__legacy__' is not available.
        
          at C:\hostedtoolcache\windows\Python\3.12.0\x64\Lib\site-packages\poetry\installation\chef.py:147 in _prepare
              143| 
              144|                 error = ChefBuildError("\n\n".join(message_parts))
              145| 
              146|             if error is not None:
            > 147|                 raise error from None
              148| 
              149|             return path
              150| 
              151|     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:
        
        Note: This error originates from the build backend, and is likely not a problem with poetry but with numpy (1.24.0) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "numpy (==1.24.0)"'.
  • Expect at least 2 child dependencies (instead of 3) in TestPipDependencyListRequirementsFallback
  • Remove the go vet in the test.yml, because it is already contained in the golangci-lint-action in analysis.yml.

@yahavi yahavi added the ignore for release Automatically generated release notes label Oct 22, 2023
@yahavi yahavi requested a review from eyalbe4 October 22, 2023 07:30
@yahavi yahavi self-assigned this Oct 22, 2023
@yahavi yahavi temporarily deployed to frogbot October 22, 2023 07:30 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor


@yahavi yahavi merged commit ce4d3c7 into jfrog:dev Oct 22, 2023
8 checks passed
@yahavi yahavi deleted the fix-poetry branch October 22, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants