Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer - Interruption may cause data loss #1010

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 26, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Halting the "transfer-files" process while delayed artifacts are being transferred might result in the early removal of the delayed artifacts file before all the chunks are properly uploaded. As a result, these files won't be uploaded unless you employ the --ignore-state flag. A similar problem can occur during the handling of error files.

This image serves as an illustration of the problem:
image

@yahavi yahavi added the bug Something isn't working label Oct 26, 2023
@yahavi yahavi requested a review from eyalbe4 October 26, 2023 08:53
@yahavi yahavi self-assigned this Oct 26, 2023
@yahavi yahavi temporarily deployed to frogbot October 26, 2023 08:53 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor


@yahavi yahavi merged commit 57aed94 into jfrog:dev Oct 31, 2023
7 of 8 checks passed
@yahavi yahavi deleted the delayed-issue branch October 31, 2023 16:38
@yahavi yahavi changed the title Transfer - Interruption may causes data loss Transfer - Interruption may cause data loss Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants