Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build scan Sarif format and remove redundant scan context message #707

Merged
merged 9 commits into from
Mar 14, 2023
Merged

Fix build scan Sarif format and remove redundant scan context message #707

merged 9 commits into from
Mar 14, 2023

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Mar 12, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

should fix #704

@sverdlov93
improve command log
b87511d 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into im…
06c837d 
…prove-npm-install
@sverdlov93
improve command log
56c14d3 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
improve command log
86df249 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 changed the title Fix build scan wrong context message and improve logs Fix build scan Sarif format and remove redundant scan context message Mar 12, 2023
@sverdlov93 sverdlov93 added the bug Something isn't working label Mar 12, 2023
@sverdlov93 sverdlov93 requested review from yahavi and eyalbe4 March 12, 2023 15:48
@sverdlov93
improve command log
5f6b7c7 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
improve command log
b98fd51 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-core into im…
ddf59fa 
…prove-npm-install

# Conflicts:
#	missioncontrol/utils/missioncontrolutils_test.go
@sverdlov93 sverdlov93 requested a review from omerzi March 14, 2023 14:23
@omerzi
Copy link
Member

omerzi commented Mar 14, 2023

LGTM

@sverdlov93
Improve usage report error logs
62e4f2c 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93
Improve usage report error logs
266ff5a 
Signed-off-by: Michael Sverdlov <michaelsv@jfrog.com>
@sverdlov93 sverdlov93 merged commit 95317b7 into jfrog:dev Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi Awaiting requested review from yahavi

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@omerzi omerzi Awaiting requested review from omerzi

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @omerzi