Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release script - install npm earlier #2298

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Release script - install npm earlier #2298

merged 2 commits into from
Nov 9, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 8, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Fix an issue introduced by this change - jfrog/jfrog-cli-core#994.
Install npm right at the start of the release process. The motivation behind this update is that jf audit now performs recursive directory scans, and except for Go, it now scans the npm package.

@yahavi yahavi added the ignore for release Automatically generated release notes label Nov 8, 2023
@yahavi yahavi requested review from eyalbe4 and attiasas November 8, 2023 13:27
@yahavi yahavi self-assigned this Nov 8, 2023
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Nov 9, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 9, 2023
@yahavi yahavi merged commit a5e2d33 into jfrog:dev Nov 9, 2023
58 of 66 checks passed
@yahavi yahavi deleted the fix-release2 branch November 9, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants