-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Distribution path mapping with AQL #2313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's add a complete description to this PR, explaiining the new functionality,
- Let's create a documentation PR to https://github.com/jfrog/documentation. This documentation repository include the source content for JFrog CLI's online documentation available at https://docs.jfrog-applications.jfrog.io/jfrog-applications/jfrog-cli.
I suggest adding a few examples to https://docs.jfrog-applications.jfrog.io/jfrog-applications/jfrog-cli/cli-for-jfrog-distribution and also updating https://docs.jfrog-applications.jfrog.io/jfrog-applications/jfrog-cli/cli-for-jfrog-artifactory#using-file-specs
} No newline at end of file | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary change which adds a redundant new-line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But gofmt makes the go file end with a newline, are you sure not to align this on current file?
Should we also create documentation in: |
schema/filespec-schema.json
Outdated
@@ -42,6 +42,19 @@ | |||
} | |||
} | |||
}, | |||
"pathMapping": { | |||
"description": "If specified, determines release-bundle source and target paths for artifacts that had been fetched using aql", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "If specified, determines release-bundle source and target paths for artifacts that had been fetched using aql", | |
"description": "If specified, determines release-bundle source and target paths for artifacts that had been fetched using aql.", |
schema/filespec-schema.json
Outdated
"properties": { | ||
"input": { | ||
"type": "string", | ||
"description": "The input path for mapping." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Configuring pathMapping
is challenging and the documentation does not explain how to do it. Let's add an example:
"description": "The input path for mapping." | |
"description": "The input path for mapping.", | |
"examples": ["(.*)/old_folder/(.*)"] |
schema/filespec-schema.json
Outdated
}, | ||
"output": { | ||
"type": "string", | ||
"description": "The output path for mapping." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "The output path for mapping." | |
"description": "The output path for mapping.", | |
"examples": ["$1/new_folder/$2"] |
Please also update |
Could you please also add a description to this PR? |
dev
branch.go vet ./...
.go fmt ./...
.Added support of "pathMapping" property to file spec in order to have the ability to control where to distribute the artifacts that are being added dynamically when using AQL in the release bundle that is being created.
When looking for docker artifacts using AQL, the release bundle also includes, in the distribution server backend, all the layers for a manifest.json and all of the manifest.json files and their layers if its a list.manifest.json
From now on the "pathMapping" will take affect on those none specified added manifests and layers and will allow the users a native way of creating the file spec for distribution commands.
FYI This couldn't be achieved using "target" for the list.manifest.json example.