Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support classifier attribute for dependency. #18

Merged
merged 1 commit into from
May 20, 2024

Conversation

asafambar
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new
    tests.

@asafambar
Copy link
Contributor Author

asafambar commented May 1, 2024

Support classifier attribute from pom.xml.
If exists its added it to dependency object and concat to its version, its part of the uniqueness of each dependency
In a Maven pom.xml file, the classifier attribute is used to specify an additional qualifier for a dependency. It allows you to differentiate between different variations or flavors of the same artifact. For example, if you have multiple versions or types of a library (e.g., a library that supports different platforms or configurations), you can use the classifier attribute to specify which one you want to include as a dependency. This helps in resolving conflicts and ensuring the correct version of the dependency is included in your project.

@attiasas attiasas requested review from yahavi and attiasas May 19, 2024 11:51
@attiasas attiasas added the improvement Automatically generated release notes label May 19, 2024
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attiasas attiasas merged commit 745f8de into jfrog:main May 20, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants